Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add angular 8 and 9 cli fixtures #8769

Merged
merged 14 commits into from
Feb 3, 2020
Merged

Add angular 8 and 9 cli fixtures #8769

merged 14 commits into from
Feb 3, 2020

Conversation

kroeder
Copy link
Member

@kroeder kroeder commented Nov 8, 2019

Issue:

What I did

Add cli fixtures for angular 8 and 9 in preparation for the angular 9 release (currently 9.0.0-rc.2)

@kroeder kroeder added ci: do not merge maintenance User-facing maintenance tasks angular labels Nov 8, 2019
@kroeder kroeder self-assigned this Nov 8, 2019
@vercel
Copy link

vercel bot commented Nov 8, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/77pyxe1sd
🌍 Preview: https://monorepo-git-add-angular-fixtures.storybook.now.sh

@ndelangen
Copy link
Member

Is this blocked until 9.0.0-rc.2 is released as latest?

@kroeder
Copy link
Member Author

kroeder commented Nov 19, 2019

Is not blocked, just have to finish it

@kroeder
Copy link
Member Author

kroeder commented Nov 20, 2019

I honestly have no idea why styles.scss causes errors in CI. It works as expected locally 😞

@ndelangen
Copy link
Member

Compare node versions?

@kroeder
Copy link
Member Author

kroeder commented Nov 26, 2019

I tried to switch to css from scss to see if this works. Now CLI tests / CLI Fixtures fails with a JS stack trace. @ndelangen can you take a look at the stack trace?

Node-version seems to be fine btw.

@ndelangen
Copy link
Member

JavaScript heap out of memory 😢

@stale
Copy link

stale bot commented Dec 18, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 18, 2019
@stale stale bot removed the inactive label Dec 20, 2019
@ndelangen
Copy link
Member

Are we trying to get this in 5.3 or is this going to be in 6.0.0?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2019

Fails
🚫 PR is marked with "in progress" label.

Generated by 🚫 dangerJS against 38e41c5

@kroeder kroeder changed the title WIP: Add angular 8 and 9 cli fixtures Add angular 8 and 9 cli fixtures Jan 31, 2020
@kroeder
Copy link
Member Author

kroeder commented Jan 31, 2020

@ndelangen @shilman updating angular 9 rc and adding one missing file finally fixed the CI issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants