-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #8504 - HTML elements get their classes dropped in MDX #8897
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/p5s7ahw22 |
See issue #8504 |
So this is a reproduction that needs a fix? |
This is a reproduction of the issue #8504 where straight HTML classes are stripped. |
@shilman do you think we should address this before 5.3 release? |
I'm adding this to my todo list |
…iterating over all exports This makes the typings MUCH more strict (and thus correct) ADD a props mapper function that changes `class` to `className` and merges and namespaces correctly REMOVE the complex iterating over all exports in html.tsx
I think this is fixed now, and TS-typings for the html elements should be much improved as well! |
@ndelangen pretty sure I fixed this when doing the MDX deep linking feature. |
Hey @patricklafrance I think the components are going to be much more strict after this PR. This just makes sure the className prop is accepted, but my change should make it so The |
FIX #8504 - HTML elements get their classes dropped in MDX
Issue: #8504
What I did
Added an example story where classes are stripped by Storybook - in cra-ts-kitchen-sink > classes stripped
How to test
If your answer is yes to any of these, please make sure to include it in your PR.