-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ember to TS #9020
Migrate ember to TS #9020
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/r61x8iay3 |
now deploy is incomplete because of some error, but locally it seems to work fine (so far) |
Verified this works, @aromanarguello Is this PR ready? |
@ndelangen Do you want me to rebase and re-push? I see some there are failures with the CI that's why I didn't want to make it |
I don't think there's a need to do that @aromanarguello, unless you want to change any code, but if not, I think it's merge-able. Will you do the honours? |
Issue: #5030