Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ember to TS #9020

Merged
merged 2 commits into from
Dec 22, 2019
Merged

Conversation

aromanarguello
Copy link
Contributor

@aromanarguello aromanarguello commented Dec 1, 2019

Issue: #5030

@vercel
Copy link

vercel bot commented Dec 1, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/r61x8iay3
🌍 Preview: https://monorepo-git-fork-aromanarguello-embertype.storybook.now.sh

@ndelangen ndelangen added this to the 6.0.0 milestone Dec 21, 2019
@ndelangen ndelangen self-assigned this Dec 21, 2019
@ndelangen
Copy link
Member

now deploy is incomplete because of some error, but locally it seems to work fine (so far)

@ndelangen
Copy link
Member

Verified this works, @aromanarguello Is this PR ready?

@aromanarguello
Copy link
Contributor Author

@ndelangen Do you want me to rebase and re-push? I see some there are failures with the CI that's why I didn't want to make it ready for review, I think I've converted every file. What are your thoughts?

@ndelangen
Copy link
Member

I don't think there's a need to do that @aromanarguello, unless you want to change any code, but if not, I think it's merge-able.

Will you do the honours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants