-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure tabs: title, visibility, order and disable #9095
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/3zsuh571u |
); | ||
})} | ||
{panels | ||
.filter(p => !p.hidden) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could store as const since this code is repeated here. Obviously the performance isn't a major issue but just in case the requirements to hide the tabs change in the future it would avoid bugs since there would only be one place to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liamross I'm merging this. perhaps you'd be able to open a follow-up PR making it just that bit nicer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndelangen I don't think it's important enough to actually change, was just a nitpick
@atanasster |
try setting |
@kumarharsh @atanasster I finally made it work by running |
@uptonking but thats hiding the addons etc right? |
@Martin7mind |
@uptonking i'd be very interested in seeing what you end up with for react-live, and would love to help you promote it in the broader storybook community |
Yeah, i got what you're saying too (facing the same issue). There is a PR (#9141) in progress which should fix this! |
@atanasster the toolbar is indeed hidden but the main content offset is still |
Hi just want to check if it is possible to make the default tab anything other than |
Issue: #8631 #8630 #7066
What I did
added the following global configuration/parameters settings:
following formats for configuration:
manager.js
:and also story specific parameters:
How to test