Fix jsconfig support with CRA

[Hypnosphi]

Issue: #9077

#6560 reportedly introduced support for jsconfig.json. Unfortunately, it lacked some important parts of logic used in CRA, like resolving the basePath relative to app directory.

Instead of copy-pasting the full logic from CRA, I just re-use the results from craWebpackConfig

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/jj3znhgbh
✅ Preview: https://monorepo-git-fix-cra-jsconfig.storybook.now.sh

[shilman]

cc @mrmckeb Does this also need to be applied to @storybook/preset-create-react-app?

[mrmckeb]

Hi @Hypnosphi, as @shilman noted, this has been deprecated and is now a separate package. I'd rather not introduce any changes here, as we will remove this completely in the next major.

Have you tried the new preset - @storybook/preset-create-react-app? Let us know if that's still an issue there. I am using this on a TypeScript project in a monorepo and it is working there.

https://github.com/storybookjs/presets/blob/master/packages/preset-create-react-app/src/helpers/getModulePath.ts

[Hypnosphi]

I'd rather not introduce any changes here

As long as it's included by default, we should at least fix the bugs

[Hypnosphi]

@mrmckeb What about all those lines? Are they, for some reason, relevant for user app itself but not for storybook?

https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/config/modules.js#L38-L64

[mrmckeb]

@Hypnosphi, out of interest, are you seeing this in the new preset - or just the deprecated in-built preset?

As long as it's included by default, we should at least fix the bugs
There are many known issues with this preset. @shilman and I discussed this a while ago, and we feel that recommending people to move to the new preset is the best path, as it solves a lot of problems and adds some new features/support.

[Hypnosphi]

seeing this in the new preset

If you mean #9077, it reproduces in the default setup, i.e. with deprecated preset. I didn't try to reproduce it with the new preset, but I think it should work OK, because you have path.join there.

What concerns me about the new preset is that CRA has some additional logic (linked above), that new preset doesn't include. So I think that getting the actual results from craWebpackConfig is a better option there as well

[mrmckeb]

The new preset does have additional logic, which resolves conflicts between Storybook and CRAs configs.

I'll leave this to @shilman to make the call - this PR looks fine to me, but again I'd much rather recommend people to move to the new preset (now the default) than to use this one.

[vasilii-kovalev]

@Hypnosphi, hello! What status of this issue? Are there any difficulties with merging this PR?

[Hypnosphi]

@vasilii-kovalev I don't have any information other than what you can read here

[shilman]

I'll merge this and patch it back to 5.3. We'll remove the built-in CRA preset in 6.0, so as far as I'm concerned it doesn't matter whether the code gets a little more complex @mrmckeb.