-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the file path for the Button story #9325
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/rjzottv5g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DaleSeo, good catch! However, the Button stories are actually located at 1-Button.stories.js
! Mind updating?
Also, this seems to be a problem across the Welcome
component in ALL frameworks. Any chance you might be able to update the others? I'd really appreciate it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DaleSeo, good catch! However, the Button stories are actually located at 1-Button.stories.js
! Mind updating?
Also, this seems to be a problem across the Welcome
component in ALL frameworks. Any chance you might be able to update the others? I'd really appreciate it!
Oops! Sorry @shamin, you're right. I've updated it! In terms of updating the others, since I'm not very familiar with this project, I just manually searched for some places and tried to update as much as I could. I also look for the vue example and found it has the correct path.
|
I think my changes break some snapshot testing. I guess I need to learn |
Thanks! Yeah, you should be able to do |
@shilman I've updated the snapshots but I think chromatic tests are failing now. Could you advise? |
Thanks @DaleSeo!! I'll take care of Chromatic & merge. Much appreciated 🙏🙏🙏 |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Correct the file path for the Button story
Issue: I happened to notice that the file path for the Button story was incorrect when looking at Storybook for React tutorial.
What I did
Corrected the file path for the Button story.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.