Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix generated entry to import at top of file #9398

Merged
merged 3 commits into from
Jan 12, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 12, 2020

Issue: #9397

What I did

Reorder the file to get rid of error

How to test

See issue. (NOTE: didn't test, but looks like a no-brainer)

@vercel
Copy link

vercel bot commented Jan 12, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/66r4n7lgj
✅ Preview: https://monorepo-git-9397-fix-generate-entry.storybook.now.sh

@Kamahl19
Copy link
Contributor

@shilman I can confirm this fixes the issue (changed it locally) although I am getting another one, I will continue in my original Issue

@Kamahl19
Copy link
Contributor

@shilman you also need to change this

import { configure, addDecorator, addParameters } from '@storybook/${framework}';

to

import { configure } from '@storybook/${framework}';

to avoid these warnings

WARNING in ./storybook/generated-entry.js
Module Warning (from ./node_modules/eslint-loader/dist/cjs.js):

  Line 2:27:  'addDecorator' is defined but never used   @typescript-eslint/no-unused-vars
  Line 2:41:  'addParameters' is defined but never used  @typescript-eslint/no-unused-vars

@shilman shilman added this to the 5.3.x milestone Jan 12, 2020
@shilman shilman merged commit 2da3a4e into next Jan 12, 2020
@shilman shilman deleted the 9397-fix-generate-entry branch January 12, 2020 15:22
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 12, 2020
shilman added a commit that referenced this pull request Jan 12, 2020
Core: Fix generated entry to import at top of file
@steven-pribilinskiy
Copy link

Hey @shilman I believe this issue #9400 is somehow connected to this PR, please check

@pksunkara
Copy link
Member

@pribilinskiy No, It's not. I am working on a fix to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants