Fixed Angular button example story #9540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property in the Angular component is lowercase. Without this change, the button example story wont work properly. (The button text isn't rendered)
devtronic
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/ndqztnot7 |
ndelangen
approved these changes
Jan 20, 2020
|
Thank you @devtronic ! |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Jan 21, 2020
Fixed Angular button example story
This was referenced Feb 12, 2020
This was referenced Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The button example story in Angular is broken. The text isn't displayed since the property name was renamed in 24ec9d3.
What I did
Made the property name lowercase.
How to test