Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix TS false default value in prop table #9560

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Addon-docs: Fix TS false default value in prop table #9560

merged 2 commits into from
Jan 21, 2020

Conversation

atanasster
Copy link
Member

Issue: #9394

What I did

Conditional check for null and undefined default prop
Added example to cra-ts-kitchen-sink

@vercel
Copy link

vercel bot commented Jan 20, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/4y6s2m0bw
✅ Preview: https://monorepo-git-fork-atanasster-prop-table-default-false.storybook.now.sh

@ndelangen ndelangen added this to the 5.3.x milestone Jan 20, 2020
@ndelangen ndelangen added addon: docs bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 20, 2020
shilman
shilman approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title prop-table: ts boolean props default false Addon-docs: Fix TS false default value in prop table Jan 21, 2020
@shilman shilman merged commit 1deaeff into storybookjs:next Jan 21, 2020
@shilman shilman deleted the prop-table-default-false branch January 21, 2020 02:55
@shilman shilman mentioned this pull request Jan 21, 2020
Closed
shilman added a commit that referenced this pull request Jan 21, 2020
@shilman
Addon-docs: Fix TS false default value in prop table (#9560)
850ca06 
Addon-docs:  Fix TS false default value in prop table
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 23, 2020
This was referenced Feb 12, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 24, 2020
Closed
Closed
Closed
Closed
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@atanasster atanasster

Labels
addon: docs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@atanasster @shilman @ndelangen