Addon-docs: Remove hard-coded lineHeight in Typeset block #9567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With lineHeight set to set 1, the bottom of the letters like 'p' gets truncated for most fonts.
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/jxbkw3uuo |
domyen
approved these changes
Jan 20, 2020
|
lgtm! thanks @philippe-lavoie 🙇♂️ |
shilman
approved these changes
Jan 21, 2020
shilman
changed the title
This was referenced Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8926
What I did
With lineHeight set to set 1, the bottom of the letters like 'p' gets truncated for most fonts.
This is to fix issue
Removed lineHeight:1
if someone wants it, he can put it in a parent's div.
How to test
Put something like
Inside a story and notice that you can see the full letter 'p' and 'y'.