IMPROVE the build-storybooks script #9569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). |
|
@gabrielcsapo @aromanarguello @dbendaou @gossi @rwjblue Would either of you be able to understand why the storybook for ember isn't building? |
|
The now.sh failure is exactly the point of this PR, it IS already failing on next, but we're not seeing it because the error isn't caught in NodeJS 10 |
|
I think I'll temporarily disable the ember example to be build to see if this is the last broken example. |
ndelangen
force-pushed
the
fix/build-storybook-script
branch
from
f0c915c
to
31ddf96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.