Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Improve Rax template #9574

Merged
merged 3 commits into from
Jan 21, 2020
Merged

CLI: Improve Rax template #9574

merged 3 commits into from
Jan 21, 2020

Conversation

SoloJiang
Copy link
Contributor

Framework Support Table typo

@vercel
Copy link

vercel bot commented Jan 21, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/jwlimi9m3
✅ Preview: https://monorepo-git-fork-solojiang-chore-supplement-rax.storybook.now.sh

shilman
shilman requested changes Jan 21, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this change put React as a heading for the addons column?

@vercel vercel bot temporarily deployed to Preview January 21, 2020 04:08 Inactive
@SoloJiang SoloJiang changed the title fix: readme fix: docs & cli about rax Jan 21, 2020
@SoloJiang
Copy link
Contributor Author

SoloJiang commented Jan 21, 2020 •
edited
Loading

Doesn't this change put React as a heading for the addons column?

Sorry, I will fix it soon.

shilman
shilman approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title fix: docs & cli about rax CLI: Improve Rax template Jan 21, 2020
@shilman shilman added maintenance User-facing maintenance tasks and removed documentation labels Jan 21, 2020
@shilman shilman added this to the 6.0.0 milestone Jan 21, 2020
@shilman shilman merged commit 8f525e8 into storybookjs:next Jan 21, 2020
@dependabot-preview dependabot-preview bot mentioned this pull request Feb 24, 2020
Closed
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

Assignees
No one assigned
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SoloJiang @shilman