Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @storybook/addon-storyshots not being able to read config from main.ts #9577

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Fix @storybook/addon-storyshots not being able to read config from main.ts #9577

merged 1 commit into from
Feb 3, 2020

Conversation

iiroj
Copy link

@iiroj iiroj commented Jan 21, 2020

Issue:

@storybook/addon-storyshots cannot read the new declarative configuration introduced in 5.3 from a TS file, but only a JS file.

What I did

This PR enables main.ts as well as main.js in the same style as as the preview and config files are loaded.

This fixes #9576

How to test

I'm new to contributing to storybook, and couldn't see any tests for this feature. I didn't add any either, but if you require I can also add tests.

@vercel
Copy link

vercel bot commented Jan 21, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/e1onvxh0w
✅ Preview: https://monorepo-git-fork-iiroj-fix-addon-storyshots-main-ts.storybook.now.sh

@iiroj iiroj changed the base branch from next to master January 21, 2020 07:15
@shilman
Copy link
Member

shilman commented Jan 21, 2020

Thanks @iiroj. Unfortunately main.ts is not supported!

@shilman shilman closed this Jan 21, 2020
@shilman shilman reopened this Feb 3, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the slow turnaround on this!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants