-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX some dependencies & ts problems on next #9603
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). |
@@ -1,4 +1,8 @@ | |||
module.exports = { | |||
stories: ['../src/stories/welcome.stories', '../src/stories/**/button.stories.js'], | |||
addons: ['@storybook/addon-actions', '@storybook/addon-links'], | |||
addons: [ | |||
'@storybook/preset-create-react-app', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This starts using the new cra preset, we'll be removing the included one in the app/react in 6.0.0
The embedded preset has a problem with the css-mini-extract plugin
@@ -14,7 +14,7 @@ interface ButtonProps { | |||
/** | |||
* default is false | |||
*/ | |||
secondary: boolean; | |||
secondary?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the story this prop isn't provided, so apparently it's optional
@@ -114,7 +114,7 @@ export const panelProps = { | |||
|
|||
const childrenToList = (children: any, selected: string) => | |||
Children.toArray(children).map( | |||
({ props: { title, id, color, children: childrenOfChild } }, index) => { | |||
({ props: { title, id, color, children: childrenOfChild } }: React.ReactElement, index) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like before in the react typings this was only React.ReactElement, but in the new typings it can also be things like portals, and strings.
We'll likely have to deal with that at some point, but for now make the typings work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Are these causing problems?
Yes, when removing polymer, the lockfile got changed, and I was hitting these issues. |
No description provided.