Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Custom Body Documentation #9613

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Conversation

smithambera
Copy link

@smithambera smithambera commented Jan 23, 2020

I'm using Storybook to document and build a design system. The design system uses relative sizing, but it is based on a 15px base font-size rather than the 16px font-size in the storybook preview.

What I did

I referred to the Storybook docs to try and solve my problem, but there was no explicit documentation for how to change the base font-size in the preview. It took me a bit to figure out, but ended up being an easy fix. I updated the Storybook documentation to explain how to update the base font-size in the preview window because I imagine a lot, lot, lot of people are using Storybook just how I am - to build a relatively-sized design system. 😄

How to test

Not much to test here, just an addition to the docs 🎉

This may be intuitive enough to some, but it took me a minute to figure out so I think it'd be nice to have here.
@vercel
Copy link

vercel bot commented Jan 23, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/gpb3r0r28
✅ Preview: https://monorepo-git-fork-smithambera-patch-3.storybook.now.sh

@ndelangen
Copy link
Member

Also of Note: I didn't pull down Storybook to suggest this update; I did all of this through GitHub because I'm only adding to the docs. All of that is to say ... I'm not sure how all those commits that aren't from me are a part of this PR. 🤷‍♀ Let me know if I need to do something differently 👍 happy to resubmit if need be!

No worries we can fix it.

I think you based off the 'master' branch (not the default branch), then made a PR against the 'next' branch (the default branch).

The preferred method is to base off of 'next' PR against 'next' and then we cherry-pick PRs to 'master'.

@smithambera
Copy link
Author

Thanks @ndelangen - I think that's exactly what happened 🤦‍♂My bad!

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 23, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@shilman shilman merged commit 5c7d9ab into storybookjs:master Jan 23, 2020
@ndelangen
Copy link
Member

@smithambera don't worry about it, it's all good. Thank you so much for the contribution!

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 4, 2020
shilman added a commit that referenced this pull request Feb 4, 2020
Update Custom Body Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants