Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation fix #9498 - theming + addon-docs incompatible #9661

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

ndelangen
Copy link
Member

Issue: #9498

What I did

ADD notices describing the incompatibilities with manager.js theming + addon-docs
Make the addon-docs README the source of truth about theming + addon-docs

…& addon-docs && make the addon-docs README the sot
@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch theming addon: docs labels Jan 28, 2020
@ndelangen ndelangen added this to the 5.3.x milestone Jan 28, 2020
@ndelangen ndelangen self-assigned this Jan 28, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@ndelangen ndelangen merged commit f955b12 into next Jan 28, 2020
@ndelangen ndelangen deleted the fix/docs-theming-compatibility-addon-docs branch January 28, 2020 15:44
@shilman shilman added documentation patch:done Patch/release PRs already cherry-picked to main/release branch and removed bug labels Jan 29, 2020
shilman pushed a commit that referenced this pull request Feb 2, 2020
documentation fix #9498 - theming + addon-docs incompatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants