MOVE addon-notes & addon-info to own repo #9673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
addon: info
maintenance
ndelangen
requested review from
alexandrebodin,
alterx,
dangreenisrael,
igor-dv,
theinterned,
usulpro and
z4o4z
as code owners
ndelangen
requested review from
matheus1lva
and removed request for
theinterned,
alterx,
dangreenisrael,
alexandrebodin,
z4o4z and
ralzinov
# Conflicts: # addons/info/package.json # addons/notes/package.json # examples/angular-cli/package.json # examples/cra-kitchen-sink/package.json # examples/cra-ts-kitchen-sink/package.json # examples/ember-cli/package.json # examples/html-kitchen-sink/package.json # examples/mithril-kitchen-sink/package.json # examples/official-storybook/package.json # examples/official-storybook/stories/addon-notes.stories.js # examples/preact-kitchen-sink/package.json # examples/rax-kitchen-sink/package.json # examples/riot-kitchen-sink/package.json # examples/svelte-kitchen-sink/package.json # examples/vue-kitchen-sink/package.json # examples/web-components-kitchen-sink/package.json
matheus1lva
approved these changes
Jan 30, 2020
shilman
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
AMEN!!! 🙏
Thanks so much for doing this @ndelangen. You just made the repo 15kloc better.
This was referenced Feb 24, 2020
saltycrane
added a commit
to saltycrane/next-storybook-typescript-example
that referenced
this pull request
Apr 7, 2020
apparently `@storybook/addon-info` [is deprecated](storybookjs/storybook#9673) in favor of [`@storybook/addon-docs`](https://github.com/storybookjs/storybook/tree/master/addons/docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: -addon-docs replaces these addons-
What I did
I moved the 2 addons into their own little monorepo.