-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Emit decorator metadata by default #9701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroeder
requested review from
alterx,
igor-dv,
ndelangen,
shilman and
stijnkoopal
as code owners
February 2, 2020 00:08
kroeder
force-pushed
the
add-emit-decorator-metadata
branch
from
February 2, 2020 00:11
83bcb01
to
d70b321
Compare
This fixes dependency injection error SomeComponent(?, ?)
kroeder
force-pushed
the
add-emit-decorator-metadata
branch
from
February 2, 2020 00:14
d70b321
to
85d5ce9
Compare
shilman
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Feb 3, 2020
shilman
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@kroeder can you update the failing test? |
I can. Haven't seen the failing tests because of the permanent false-positive A11y 😞 |
shilman
changed the title
Emit decorator metadata by default
Angular: Emit decorator metadata by default
Feb 3, 2020
shilman
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Feb 4, 2020
shilman
added a commit
that referenced
this pull request
Feb 4, 2020
Angular: Emit decorator metadata by default
This was referenced Feb 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
angular
bug
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7544
What I did
I added
emitDecoratorMetadata: true
as default value to the ts compiler options. Angular dependency injection does not work correctly without itHow to test
ng new test-app
sb init
node_modules/@storybook/angular/server/ts_config.js