Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cra-ts-kitchen-sink: Fix stories glob pattern #9706

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Conversation

swlee93
Copy link

@swlee93 swlee93 commented Feb 2, 2020

Issue:
When we started the storybook of cra-ts-kitchen-sink , we had a situation loading only the mdx format files, unlike our intention to verify the story of the components written with type scripts.

What I did

The matching pattern of the stories defined in main.js has been changed.

@shilman shilman added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 2, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!! There's something up with the lockfile which is breaking the build. I'll follow up and get it sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants