Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert 'yarn' command between 'cd storybook' and 'yarn bootstrap (--core)' #9708

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Insert 'yarn' command between 'cd storybook' and 'yarn bootstrap (--core)' #9708

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1b64cb
Insert 'yarn' command between 'cd storybook' and 'yarn bootstrap (--c…
yeseouler Feb 2, 2020
e307ca4
Update CONTRIBUTING.md
shilman Feb 6, 2020
e79e80f
Update CONTRIBUTING.md
shilman Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ cd storybook
yarn bootstrap
```

> NOTE: on windows you may need to run `yarn` before `yarn bootstrap`!

The bootstrap command might ask which sections of the codebase you want to bootstrap. Unless you're going to work with ReactNative or the Documentation, you can keep the default.

You can also pick directly from CLI:
Expand Down Expand Up @@ -140,6 +142,8 @@ git clone https://github.com/storybookjs/storybook.git
cd storybook
yarn bootstrap --core

# NOTE: on windows you may need to run `yarn` before `yarn bootstrap`!

# make changes to try and reproduce the problem, such as adding components + stories
cd examples/cra-kitchen-sink
yarn storybook
Expand Down Expand Up @@ -263,10 +267,11 @@ If you run into trouble here, make sure your node, npm, and **_yarn_** are on th
1. `cd ~` (optional)
2. `git clone https://github.com/storybookjs/storybook.git` _bonus_: use your own fork for this step
3. `cd storybook`
4. `yarn`
5. `yarn bootstrap --core`
6. `yarn test --core`
7. `yarn dev` _You must have this running for your changes to show up_
4. `yarn bootstrap --core`
5. `yarn test --core`
6. `yarn dev` _You must have this running for your changes to show up_

> NOTE: on windows you may need to run `yarn` before `yarn bootstrap` (between steps 3 and 4).

#### Bootstrapping everything

Expand Down