Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #9716 from sakito21/fix/docs-configurations-typescript-config #9716

Merged

Conversation

sakit0
Copy link
Contributor

@sakit0 sakit0 commented Feb 3, 2020

What I did

awesome-typescript-loader was archived.

I think it's better to change Document awesome-typescript-loader to ts-loader so as not to confuse users.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can one of our typescript experts approve? @kroeder @gaetanmaisse @mrmckeb ?

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch typescript labels Feb 3, 2020
Copy link
Member

@gaetanmaisse gaetanmaisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅LGTM. All refs to awesome-typescript-loader were removed from TS Handbook too.

@shilman shilman added this to the 5.3.x milestone Feb 4, 2020
@shilman shilman changed the title [Docs] configurations/TypeScript Config awesome-typescript-loader to ts-loader Merge pull request #9716 from sakito21/fix/docs-configurations-typescript-config Feb 4, 2020
@shilman shilman merged commit 8b28913 into storybookjs:master Feb 4, 2020
@sakit0 sakit0 deleted the fix/docs-configurations-typescript-config branch February 4, 2020 08:18
@sakit0
Copy link
Contributor Author

sakit0 commented Feb 4, 2020

Thank you🐕

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 4, 2020
shilman added a commit that referenced this pull request Feb 4, 2020
…ript-config

[Docs] configurations/TypeScript Config awesome-typescript-loader to ts-loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants