Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte: Fix Svelte 3 slots for decorators #9724

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

tonai
Copy link
Contributor

@tonai tonai commented Feb 3, 2020

Issue: #8384

Fix centered addon decorator for Svelte 3.
Also fix other addons that uses decorators for Svelte 3.

What I did

I implemented the workaround from here sveltejs/svelte#2588 (comment) (with some adaptations and corrections).

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes
  • Does this need a new example in the kitchen sink apps? No it already exists in svelte-kitchen-sink
  • Does this need an update to the documentation? No

I got a problem with the Jest snapshots because the test in this file should fail without the fix.
It is easily visible when testing manually with the svelte-kitchen-sink example app.

@shilman shilman changed the title Fix Svelte 3 slots for decorators. Svelte: Fix Svelte 3 slots for decorators Feb 4, 2020
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 4, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tonai !!!

@shilman shilman added this to the 5.3.x milestone Feb 4, 2020
@shilman shilman merged commit cfeb47d into storybookjs:next Feb 4, 2020
@tonai
Copy link
Contributor Author

tonai commented Feb 4, 2020

Thanks @shilman for approving my PR.

Though, I am a little concerned about the jest snapshot test that should have fail.
This issue should have been raised with automated testing.
I wonder if there is other hidden cases like this 😟

@shilman
Copy link
Member

shilman commented Feb 4, 2020

@tonai I approved the changes in chromatic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch svelte
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants