Core: Fix dev server error - back out bad change #9753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Feb 4, 2020
shilman
added
patch:yes
shilman
added a commit
that referenced
this pull request
Feb 4, 2020
Fix dev server error - back out bad change
shilman
changed the title
This was referenced Feb 24, 2020
Closed
sh0ji
added a commit
to wwnorton/design-system
that referenced
this pull request
Jul 17, 2020
5.3.11 had a change that broke the storybook server. storybookjs/storybook#9753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9749
What I did
Revert bad change to dev server. It's not actually failing in my local dev server (
official-storybook), so I'm not sure how to repro. But it seems to be affecting a lot of people, so trusting the crowd here.How to test
N/A - not sure how to repro