Addon-docs: Snapshot testing and bug reporting for props tables #9838
Conversation
shilman
added
maintenance
| fixtures.forEach(fixture => { | ||
| // eslint-disable-next-line import/no-dynamic-require, global-require | ||
| const { component } = require(`./__testfixtures__/${fixture}/input`); | ||
| const props = extractProps(component); | ||
| stories.add(fixture, () => <PropsTable {...props} />); | ||
| }); |
There was a problem hiding this comment.
We could also just manually do the exports so this file can be CSF
| selector: 'doc-button', | ||
| }) | ||
| export class InputComponent<T> { | ||
| @ViewChild('buttonRef', { static: false }) buttonRef: ElementRef; |
There was a problem hiding this comment.
| @ViewChild('buttonRef', { static: false }) buttonRef: ElementRef; | |
| @ViewChild('buttonRef') buttonRef: ElementRef; |
this defaults to false in Angular 9 (I think the angular 9 update PR should be merged already? 🤔 )
Not super important but makes it easier to read
|
@shilman So, are typescript prop tables supported natively on the latest beta without edit: I'm asking because I can't find any explicit reference to that in the pr :) |
|
Yes. Still working out the dependencies tho |
|
Hi @shilman, I would like to know any news about props table for Vue, I'm currently testing on |
Issue: #9836
What I did
How to test
See attached tests