Ts/better api consumer #9861
Merged
Ts/better api consumer #9861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponent a FunctionComponent that auto-memoizes
gaetanmaisse
approved these changes
Feb 14, 2020
This was referenced Dec 16, 2020
This was referenced Feb 22, 2021
This was referenced Apr 21, 2021
This was referenced May 26, 2021
This was referenced Jun 8, 2021
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Using Consumer component with a state filter isn't as optimized as it could be
What I did
I improved the typings of lib/api's Consumer component.
It now automatically does typing for the children function
It also automatically only re-renders the component when some has changed in the return value of the state filter function.