Refactor Client API: pull metadata handling code into the store. #9877
Conversation
Bring this handling all into one place and make it easier to understand what is going on. Still needs tests and to resolve some loose ends.
Always merge to arbitrary depth.
|
@tmeasday does this also include the "don't merge arrays" change? |
Not yet but it will |
tmeasday
requested review from
alexandrebodin,
CodeByAlex,
jbovenschen,
leonrodenburg and
theinterned
as code owners
tmeasday
force-pushed
the
refactor-client-api
branch
from
209912c
to
fc21e56
Compare
|
@ndelangen / @shilman - any idea about this failing knobs cypress test? I think the issue comes from here: https://github.com/storybookjs/storybook/blob/0a2d97267376e803ac9ad82c18f661100dd15354/addons/knobs/src/registerKnobs.ts#L12:L12 The test grabs the knob value without waiting the 325ms so I think the story re-renders after it begins to check it. However I am not sure why it would have started failing on this branch. I don't really think I touched the code path that goes from the knob changing a value, emitting the force re-render event and then rendering the story (the last bit, sure but I don't think the new code would render it significantly differently). Should I just add a |
|
There should be no need for a |
|
I tested it locally, and it seemed to work, i think it's fixed now |
|
@tmeasday can you take a look at the failing chromatic test? it looks like the parameters got reordered and i'm not sure i understand why -- seems like it could potentially introduce subtle bugs in user code? |
Yeah I don't get it, it doesn't order them in that order here :/ |
|
Actually the order seems correct to me; docs is the first addon loaded by |
| import { withA11Y } from '../index'; | ||
|
|
||
| addDecorator(withA11Y); | ||
| export const decorators = [withA11Y]; |
There was a problem hiding this comment.
Do you want to document this in MIGRATION.md?
There was a problem hiding this comment.
Yeah I wasn't sure if we document new features in there or not. The old way is still supported 🤷♂
|
Going to merge this and follow up on some other points later. |
Part one of a
@storybook/client-apirefactor.Bring metadata (parameters + decorators) logic into the story store.
The
client_apifile is now a simpler wrapper around the store and does not include any state.In the future we may keep parameters "decomposed" and pass them over the channel as such, for now we still combine them together at story add time.
For other key changes in the PR, please see the
MIGRATION.mdnotes:https://github.com/storybookjs/storybook/pull/9877/files#diff-177dcef0a5b481c2c87db87f7cdf200d