Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): capture unknown arguments the native way #9888

Merged
merged 1 commit into from
Feb 18, 2020
Merged

fix(cli): capture unknown arguments the native way #9888

merged 1 commit into from
Feb 18, 2020

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Feb 17, 2020 •
edited
Loading

closes #9887

It seems commander.js fails to capture the exact unknown command passed in. A solution would be to pick it up from the native process.argv.

@jamesgeorge007 jamesgeorge007 changed the title fix: capture unknown arguments fix(cli): capture unknown arguments Feb 17, 2020
@jamesgeorge007 jamesgeorge007 self-assigned this Feb 17, 2020
@jamesgeorge007 jamesgeorge007 added this to the 6.0.0 milestone Feb 17, 2020
@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 2bf90aa

@jamesgeorge007 jamesgeorge007 added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 17, 2020
@jamesgeorge007 jamesgeorge007 changed the title fix(cli): capture unknown arguments fix(cli): capture unknown arguments the native way Feb 17, 2020
@jamesgeorge007 jamesgeorge007 merged commit 60ab368 into next Feb 18, 2020
@jamesgeorge007 jamesgeorge007 deleted the hotfix/suggest-cmd branch February 18, 2020 12:58
@shilman shilman added bug cli and removed high priority patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 18, 2020
@shilman shilman mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman Awaiting requested review from shilman

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

Assignees

@jamesgeorge007 jamesgeorge007

Labels
bug cli
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

Passing in an unknown command throws error
3 participants
@jamesgeorge007 @ndelangen @shilman