ADD stories for layout in mdx as example and regression test #9940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested changes
Feb 24, 2020
| title: 'Core/Layout MDX', | ||
| }; | ||
|
|
||
| export const Default = () => <Box>padded by default</Box>; |
There was a problem hiding this comment.
All these functions need to be in a CSF file @ndelangen
There was a problem hiding this comment.
I deleted all those exports, they aren't needed.
shilman
added
maintenance
shilman
reviewed
Feb 24, 2020
shilman
reviewed
Feb 24, 2020
|
@ndelangen when trying this, I’m seeing the docs tab also applying those styles which means that everything in the docs tab gets centered |
|
@ndelangen are these showing up in chromatic? not seeing this in the PR badge: "383 tests unchanged" |
|
They show up, I've already accepted them here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9229 (comment)
What I did
Added a few examples