Experiment to make CircleCI tests a faster and more stable #9969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonspalmer
force-pushed
the
faster_tests
branch
from
dc9bd2e to
6f42333
Compare
shilman
added
maintenance
ndelangen
approved these changes
Feb 27, 2020
jamesgeorge007
approved these changes
Feb 29, 2020
# Conflicts: # .github/workflows/tests-puppeteer.yml # examples/official-storybook/package.json # yarn.lock
shilman
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Experiment to see if we can make CircleCI a little faster by not schlepping a Chromium binary around all the build steps
Puppeteer comes with an installed copy of chromium which we then tar and pass around in our node_module caches in GitHub actions and CircleCI workspaces. Removing the hard dependency saves about 90MB of tared node modules we don't have to cache.
Only a single set of tests (which are failing) need Puppeteer and just install in when we need it. It's also likely that we can simply use Chrome installed on the Docker images we using.
[ ] Add documentation on running puppeteer tests locally (needs to install Chomre/Chromium)
[ ] Explore using Chrome on CI vendor's docker images