Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getStorybookMain to throw an error if stories are not found in main.js #278

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Mar 13, 2023

Closes #277

What I did

Updated getStorybookMain to throw an error if stories are not found in main.js

📦 Published PR as canary version: 0.9.5--canary.278.4ef4cb1.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.9.5--canary.278.4ef4cb1.0
# or 
yarn add @storybook/test-runner@0.9.5--canary.278.4ef4cb1.0

Version

Published prerelease version: v0.10.0-next.11

Changelog

🚀 Enhancement

🐛 Bug Fix

📝 Documentation

Authors: 9

@valentinpalkovic valentinpalkovic added the bug Something isn't working label Mar 13, 2023
@valentinpalkovic valentinpalkovic self-assigned this Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.95 🎉

Comparison is base (f2191b7) 75.00% compared to head (4ef4cb1) 75.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #278      +/-   ##
==========================================
+ Coverage   75.00%   75.95%   +0.95%     
==========================================
  Files          11       11              
  Lines         176      183       +7     
  Branches       37       39       +2     
==========================================
+ Hits          132      139       +7     
  Misses         44       44              
Impacted Files Coverage Δ
src/util/getStorybookMain.ts 92.85% <91.66%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinpalkovic valentinpalkovic force-pushed the valentin/throw-error-on-undefined-stories-config branch 2 times, most recently from 9d8f112 to 6cc4aba Compare March 13, 2023 09:16
@valentinpalkovic valentinpalkovic force-pushed the valentin/throw-error-on-undefined-stories-config branch from 6cc4aba to 4ef4cb1 Compare March 13, 2023 09:21
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks and works great, thanks a lot <3

@yannbf yannbf added the patch Increment the patch version when merged label Mar 15, 2023
@yannbf yannbf merged commit 6427b31 into next Mar 15, 2023
This was referenced Mar 31, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

🚀 PR was released in v0.10.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'map')
2 participants