Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to 2.0 #1

Open
4 of 8 tasks
almeynman opened this issue Mar 29, 2018 · 3 comments
Open
4 of 8 tasks

Road to 2.0 #1

almeynman opened this issue Mar 29, 2018 · 3 comments
Milestone

Comments

@almeynman
Copy link
Contributor

almeynman commented Mar 29, 2018

  • setup automatic testing similar to https://github.com/elevatebart/vue-cli-plugin-template-loader
  • if babel configuration is in package.json load it as custom storybook configuration. Wait for Migrate to babel@7.0.0-beta storybook#3335
  • If .babelrc does not exist at the root of the project, generate .babelrc file in the storybook
  • if vueStorybook flag is set to true add relevant webpack configurations to service (index.js) and add blocks to components
  • if classComponent flas is set to true
  • make with JSX example work with all setups
  • allow writing stories in .story.js/ts and in nested structures
  • write usage details in readme
@pksunkara pksunkara added this to the 1.0.0 milestone Jul 23, 2018
@pksunkara
Copy link
Member

@almeynman Could you explain what you mean by vueStorybook flag and classComponent flag.

@almeynman
Copy link
Contributor Author

@pksunkara
vueStorybook is a package that allows to add custom <story> blocks.
classComponent flag is needed in case the project is configured to use class components. There was some difference in storybook configuration. I don't remember exactly which.

@backbone87
Copy link
Contributor

i would recommend against vueStorybook in its current form. while its a neat feature, the way its implementated seems rather inflexible.

@pksunkara pksunkara changed the title Road to 1.0 Road to 2.0 Jan 15, 2020
pksunkara pushed a commit that referenced this issue Oct 15, 2020
pksunkara pushed a commit that referenced this issue Oct 15, 2020
This reverts commit 3610a91, reversing
changes made to 90edd40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants