Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable svelte-vite/default-ts template #19369

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Oct 5, 2022

This PR re-enables the svelte-vite/default-ts template.

It was originally disabled in an attempt to fix the flaky sandbox smoke tests at cddd195 but it didn't appear to have worked, so I don't think it makes sense to have it disabled anymore.

Related to #19351 and #19351

@JReinhold JReinhold added svelte build Internal-facing build tooling & test updates labels Oct 5, 2022
@JReinhold JReinhold marked this pull request as ready for review October 5, 2022 22:34
@JReinhold JReinhold self-assigned this Oct 5, 2022
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can follow the strategy to just disable the smoke-test task for this template if necessary. If so we should make sure we document that we need to re-check that after updating node/execa.

@JReinhold JReinhold merged commit 93f9090 into next Oct 6, 2022
@JReinhold JReinhold deleted the reenable-svelte-vite-ts-template branch October 6, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates svelte
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants