Add new SET_INDEX event #19590
Merged
Add new SET_INDEX event #19590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer try and do docs-page manager side.
Also ensure that the ClientAPI calculates the index correctly
…om/sb-732-docs2-support-docs-only-stories-in-v6
tmeasday
changed the base branch from
next
to
tom/sb-849-cant-run-the-v6-store-in-sandboxes-2
…om/sb-732-docs2-support-docs-only-stories-in-v6
…om/sb-732-docs2-support-docs-only-stories-in-v6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #19595
Issue: #19126
Docs-only stories didn't work properly with Story Store V6, as the
SET_STORIESevent didn't include docs entries.What I did
Add a
SET_INDEXevent (with the same structure asindex.json). This simplifies both the preview+manager handling, but means we lose composition compatibility between v6 and v7.How to test
(currently not possible, working on that).