Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable keyboard shortcuts during (docs) play functions and add tests #19668

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Disable keyboard shortcuts during (docs) play functions and add tests #19668

merged 6 commits into from
Oct 31, 2022

Conversation

tmeasday
Copy link
Member

Issue: If users autoplay in docs, we don't want to trigger keyboard shortcuts

What I did

  • Extend existing mechanism to also disable during docs play
  • Add unit tests, stories and e2e tests

How to test

See tests. Visit the shortcuts stories in docs mode.

@tmeasday tmeasday requested a review from shilman October 28, 2022 12:40
shilman
shilman approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🌟

@tmeasday tmeasday merged commit 8bcf78d into next Oct 31, 2022
@tmeasday tmeasday deleted the tom/sb-889-disable-keyboard-shortcuts-during-the branch October 31, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
addon: docs addon: interactions bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman