Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-vite: Fix perf regression by pinning vite-plugin-react-docgen-ts #22013

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 10, 2023

Closes #22011

What I did

It seems as if joshwooding/vite-plugin-react-docgen-typescript#17 might have caused a huge performance regression. This is likely causing problems for end users and might also be what has broken CI for the storybook repo.

How to test

  • CI passes

@shilman shilman added dependencies react patch:yes Bugfix & documentation PR that need to be picked to main branch builder-vite labels Apr 10, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@joshwooding/vite-plugin-react-docgen-typescript@0.2.1 0.2.2...0.2.1 None +1/-0 joshwooding

@dhess
Copy link

dhess commented Apr 10, 2023

I can confirm that by using a pnpm override in our package.json, pinning this package to 0.2.1 fixes #22011.

dhess added a commit to hackworthltd/primer-app that referenced this pull request Apr 10, 2023
See:

storybookjs/storybook#22011
storybookjs/storybook#22013

Once the latter PR is included in a Storybook release, we can undo
this workaround.
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

joshwooding/vite-plugin-react-docgen-typescript#17 is the change upstream that seems to have caused the issue.

@valentinpalkovic @joshwooding we may need to take another swing at this.

@shilman shilman merged commit a8d770f into next Apr 10, 2023
@shilman shilman deleted the shilman/fix-vite-react-docgen branch April 10, 2023 15:45
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 10, 2023
shilman added a commit that referenced this pull request Apr 10, 2023
React-vite: Fix perf regression by pinning vite-plugin-react-docgen-ts
dhess added a commit to hackworthltd/primer-app that referenced this pull request Apr 10, 2023
See:

storybookjs/storybook#22011
storybookjs/storybook#22013

Once the latter PR is included in a Storybook release, we can undo
this workaround.
@shilman shilman mentioned this pull request May 22, 2023
@htmlin
Copy link

htmlin commented Sep 12, 2023

https://github.com/joshwooding/vite-plugin-react-docgen-typescript/releases/tag/v0.2.3
It seems that joshwooding/vite-plugin-react-docgen-typescript has released a new version to fix the problem. Can we upgrade it again?

@IanVS
Copy link
Member

IanVS commented Sep 12, 2023

We can but so far it's identical so there's no need. A new version is coming soon to support vite 5, then we'll update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder-vite dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Extreme performance regression from Storybook v6 -> v7
4 participants