-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React-vite: Fix perf regression by pinning vite-plugin-react-docgen-ts #22013
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
I can confirm that by using a pnpm override in our |
See: storybookjs/storybook#22011 storybookjs/storybook#22013 Once the latter PR is included in a Storybook release, we can undo this workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
joshwooding/vite-plugin-react-docgen-typescript#17 is the change upstream that seems to have caused the issue.
@valentinpalkovic @joshwooding we may need to take another swing at this.
React-vite: Fix perf regression by pinning vite-plugin-react-docgen-ts
See: storybookjs/storybook#22011 storybookjs/storybook#22013 Once the latter PR is included in a Storybook release, we can undo this workaround.
https://github.com/joshwooding/vite-plugin-react-docgen-typescript/releases/tag/v0.2.3 |
We can but so far it's identical so there's no need. A new version is coming soon to support vite 5, then we'll update. |
Closes #22011
What I did
It seems as if joshwooding/vite-plugin-react-docgen-typescript#17 might have caused a huge performance regression. This is likely causing problems for end users and might also be what has broken CI for the storybook repo.
How to test