Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate License Terms allowed on Registering Derivative IP #41

Closed
jdubpark opened this issue Apr 8, 2024 · 0 comments · Fixed by #75
Closed

Duplicate License Terms allowed on Registering Derivative IP #41

jdubpark opened this issue Apr 8, 2024 · 0 comments · Fixed by #75
Assignees
Labels
bug Something isn't working high priority license

Comments

@jdubpark
Copy link

jdubpark commented Apr 8, 2024

Expected Behavior

Can only link to parents using unique License Terms. If the user mints two or more License Tokens of the same License Terms from the same parent, and attempts to link to that parent using all of the License Tokens, it should revert.

Actual Behavior

Linking to a parent with two or more of the same License Tokens (different IDs, since mint amount > 1) is permitted.

  1. Mint two or more license tokens of the same terms (e.g. Non-Commercial Social Remix) from a parent
  2. Use all the license tokens from (1) to link a single IP to the parent from (1).

Example

  • IPA 1 is root
  • IPA 2 is child of IPA 1
  • IPA 3 is child of IPA 2
  • All licenses used are commercial with 10% royalty

Below results are produced

Case 1: If IPA 2 is linked to IPA 1 using one license (and the same between IPA 2 and 3), then

  • IPA 1 has 10% over IPA 2
  • IPA 1 has 20% over IPA 3
  • IPA 2 has 10% over IPA 3

Case 2 (bug): If IPA 2 is linked to IPA 1 using two same licenses (and IPA 3 is linked to IPA 2 using one license), then

  • IPA 1 has 20% over IPA 2
  • IPA 1 has 30% over IPA 3
  • IPA 2 has 10% over IPA 3
@jdubpark jdubpark added bug Something isn't working question Further information is requested labels Apr 8, 2024
@jdubpark jdubpark changed the title Duplicate License Terms on Registering Derivative IP Duplicate License Terms allowed on Registering Derivative IP Apr 8, 2024
@LeoHChen LeoHChen added this to the v1 code freeze milestone Apr 11, 2024
@jdubpark jdubpark removed the question Further information is requested label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority license
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants