Detect and Revert Duplicate License Terms #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingster-will
requested review from
Ramarti,
leeren,
jdubpark,
Spablob,
LeoHChen and
AndyBoWu
as code owners
LeoHChen
reviewed
Apr 12, 2024
LeoHChen
reviewed
Apr 12, 2024
jdubpark
approved these changes
Apr 12, 2024
The return value is for indicating whether the item has already exist in the Set. As this is the only one function to register derivative relationship between child Ip and parent IP need to check duplicate. no other place need this check. |
LeoHChen
approved these changes
Apr 12, 2024
jdubpark
pushed a commit
to jdubpark/sp-protocol-core
that referenced
this pull request
Apr 14, 2024
* Duplicate licenses revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR detects duplicate license terms when registering derivative and revert operations.
Closes #41