Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Global Permission in IP Access Control #57

Closed
jdubpark opened this issue Apr 11, 2024 · 1 comment
Closed

Remove Global Permission in IP Access Control #57

jdubpark opened this issue Apr 11, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request high priority IP-ACL IP-specific Access Control system

Comments

@jdubpark
Copy link

The old IP ACL system required each IP Account to allow module-to-module (M2M) calls, such as the Licensing Module calling the Royalty Module. To remove this ACL friction, global permission was introduced where the first mapping ipAccount was set to address(0) by the protocol governance to indicate a wildcard.

However, using the IP-specific ACL system for M2M interactions introduces potential security risks as well as unintended side consequences of using a wildcard. Hence, we should remove the global permission.

Then, to facilitate the core M2M interactions, which are known in advance, we should use custom, per-module modifiers to gate calls to functions. While this fulfills the requirement handled by the global permission, it can be structurally improved with a dedicated ACL for M2M calls (at the expensive of slightly higher gas cost).

@jdubpark jdubpark added enhancement New feature or request IP-ACL IP-specific Access Control system labels Apr 11, 2024
@jdubpark jdubpark added this to the v1 code freeze milestone Apr 11, 2024
@LeoHChen
Copy link
Member

Fixed in #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority IP-ACL IP-specific Access Control system
Projects
None yet
Development

No branches or pull requests

3 participants