Enhanced Access Control: Removal of Global Permissions, Direct Permission Setting, and External Contract Calls by IP Owners #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingster-will
requested review from
Ramarti,
leeren,
jdubpark,
Spablob,
LeoHChen and
AndyBoWu
as code owners
jdubpark
approved these changes
Apr 14, 2024
Ramarti
reviewed
Apr 14, 2024
LeoHChen
approved these changes
Apr 14, 2024
Ramarti
reviewed
Apr 14, 2024
LeoHChen
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes three significant changes to the access control mechanism in our Solidity contracts, specifically in the
AccessController.solfile.Removal of Global Permissions: Removes the concept of global permissions. Previously, permissions were able to set at a global level. With this change, permissions are now can only set at a more granular level, providing better control and security.
Direct Permission Setting by IP Owners: Allows IP owners to directly set permissions, no need through the
IPAccountcontract. This change simplifies the process of setting permissions and makes it more intuitive for IP owners.IP Owners Can Call External Contracts: Allows IP owners to call any external contracts through their
IPAccount. This provides IP owners with greater flexibility and control over their IP, enabling them to interact with a wider range of contracts and services.