Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove & Rename Errors and Correct Names #112

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Remove & Rename Errors and Correct Names #112

merged 6 commits into from
Apr 16, 2024

Conversation

jdubpark
Copy link

This PR

  • Removes unused Errors from beta and v1.0.0-rc.1
  • Rename some Errors for unified naming
  • Corrects some variable names
  • Removes some unnecessary comments

Spablob
Spablob reviewed Apr 16, 2024
View reviewed changes
contracts/lib/Errors.sol Outdated Show resolved Hide resolved
Spablob
Spablob reviewed Apr 16, 2024
View reviewed changes
contracts/lib/Errors.sol Outdated Show resolved Hide resolved
Spablob
Spablob reviewed Apr 16, 2024
View reviewed changes
contracts/lib/Errors.sol Outdated Show resolved Hide resolved
@jdubpark jdubpark merged commit b4741d9 into storyprotocol:main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spablob Spablob Spablob approved these changes

@LeoHChen LeoHChen LeoHChen approved these changes

@kingster-will kingster-will Awaiting requested review from kingster-will kingster-will is a code owner

@Ramarti Ramarti Awaiting requested review from Ramarti

@leeren leeren Awaiting requested review from leeren

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdubpark @LeoHChen @Spablob