Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename event #130

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Rename event #130

merged 1 commit into from
Apr 19, 2024

Conversation

Spablob
Copy link

@Spablob Spablob commented Apr 19, 2024

Description

This pr renames event RoyaltyTokenAddedToVault to RevenueTokenAddedToVault for more clarity

Related Issue

Issue #118

jdubpark
jdubpark approved these changes Apr 19, 2024
View reviewed changes
Copy link

@jdubpark jdubpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please notify the SDK team of the change, the indexer needs to change to reflect the renaming.

@LeoHChen LeoHChen merged commit 4c0a79b into storyprotocol:main Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingster-will kingster-will kingster-will approved these changes

@jdubpark jdubpark jdubpark approved these changes

@Ramarti Ramarti Awaiting requested review from Ramarti

@leeren leeren Awaiting requested review from leeren

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Spablob @jdubpark @kingster-will @LeoHChen