Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing License Terms ID in tokenURI() Function #136

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

kingster-will
Copy link

Description

Overview

This pull request addresses the issue where the tokenURI() function in the LicenseToken does not return metadata containing the license terms ID. The fix ensures that the license terms ID is correctly appended to the URI string. Additionally, this PR also adding unit test to verify that the tokenURI() function returns the expected base64-encoded string containing all necessary metadata.

Changes Made

  1. Function Update: Modified the tokenURI() function to concatenate the license terms ID to the metadata URI.
  2. Unit Test Addition: Added a new unit test in LicenseToken.t.sol to ensure the returned URI is correctly base64 encoded and includes the license terms ID.

Test Plan

  • Verify that all tests pass, including the new test for the tokenURI() function.

Related Issue

Closes #135

@LeoHChen LeoHChen merged commit be00194 into storyprotocol:main Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LicenseToken tokenURI() Function Missing License Terms ID in Return
3 participants