Added storage layout safety check on deployment and GHA #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
requested review from
kingster-will,
leeren,
jdubpark,
Spablob,
LeoHChen and
AndyBoWu
as code owners
LeoHChen
approved these changes
Mar 24, 2024
kingster-will
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the OZ Foundry plugin
deployProxymethods, which check for layout safety but are slow and require us to use only clean builds and--ffion tests, we are going to use a different strategy:StorageLayoutChecker.sol) that runs the OZ cli first thing onrun, failing if layouts are not safe.NOTE: I removed
libfrom .gitignore since we need it to install OZ plugin. Git submodules seem safe to add