Introducing IPAccount Namespace Storage and IViewModule for Enhanced Metadata Display #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingster-will
force-pushed
the
v1/oda-namespace
branch
from
65351a1
to
a176f95
Compare
LeoHChen
approved these changes
Mar 15, 2024
|
Can you tag me as a reviewer too next time? I want to follow and understand the PR changes so I can notify others of any impacting changes when I help them @kingster-will @LeoHChen. Thanks |
kingster-will
added a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Mar 19, 2024
…Metadata Display (storyprotocol#2) * IPAccount storage impl * emit old IPRegistered event * add premissionless register() function into IIPAssetRegistry interface * reduce setter/getter in IPAccountStorage Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces significant enhancements to the StoryProtocol, focusing on the IPAccount Namespace Storage and the introduction of a new module type,
IViewModule, aimed at offering flexibility in displaying metadata. Additionally, it incorporates a fully permissionless registration function for IPAssets. The key highlights and changes are as follows:IPAccount Namespace Storage
The implementation of IPAccount Namespace Storage is realized through the
IPAccountStoragecontract, which adheres to theIIPAccountStorageinterface. This development facilitates structured and conflict-free data storage for IPAccounts by employing a namespaced storage pattern. The default namespace is determined by themsg.sender, ensuring that only the owning Module can write data into its respective namespace, while read operations remain unrestricted across namespaces.IViewModule Introduction
A new module type,
IViewModule, has been introduced to enhance the flexibility in displaying metadata. This module type allows for a more dynamic and customizable presentation of IPAssets, catering to the diverse needs of different applications and user interfaces.Test Coverage
The newly added code, including the IPAccount Namespace Storage and the
registerfunction, has achieved 100% test code coverage, ensuring reliability and robustness.This PR represents a pivotal step forward in the StoryProtocol's development, introducing advanced features that enhance functionality, flexibility, and accessibility.