Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Non-Commercial Remix License as Default License in Deployment Script and Ensure Consistent API Behavior #235

Merged

Conversation

kingster-will
Copy link

Description

This PR configures the non-commercial remix license as the default license in the deployment script as license terms ID 1, ensuring that the default license terms are set during the deployment of protocol contracts. Additionally, it updates the License Registry API to handle the default license terms consistently.

Key Changes

  • Deployment Script Update: Configured the non-commercial remixable license as the default license.
  • API Consistency: Updated the License Registry API to handle the default license terms consistently:
    1. getAttachedLicenseTerms(): Default license terms will be the last one attached to the IP.
    2. getAttachedLicenseTermsCount(): Default license terms are also counted.
    3. hasIpAttachedLicenseTerms(): Default license terms are considered attached to the IP.

Objectives

  • Set Default License: Ensure the non-commercial remixable license is set as the default license during deployment.
  • Consistent API Behavior: Make the License Registry API handle default license terms consistently.

Copy link
Member

@sebsadface sebsadface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kingster-will kingster-will merged commit c83bbee into storyprotocol:main Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants