This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Limit the last node of a derivative chain to mint licenses #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoHChen
reviewed
Feb 17, 2024
LeoHChen
reviewed
Feb 17, 2024
LeoHChen
force-pushed
the
add-max-parent-on-minting-license
branch
from
a11c046
to
0ba59ad
Compare
LeoHChen
approved these changes
Feb 17, 2024
kingster-will
referenced
this pull request
in kingster-will/protocol-core-v1-dev
Mar 19, 2024
…ocol#106) * add contract and unit test adjustments to limit license minting for last node * add comment and fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last node of a derivative chain is not able to have more derivatives - it should also not be able to mint licenses given they serve no purpose other than allowing derivative creation to protect the potential license buyers.