This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Refactor Initialization process of IPAccount registration #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoHChen
reviewed
Feb 17, 2024
LeoHChen
approved these changes
Feb 17, 2024
kingster-will
force-pushed
the
ipaccountimpl
branch
from
5eddbae
to
d3a8820
Compare
|
Would be nice to merge after #109 to keep the NatSpec and variable standards in check |
LeoHChen
approved these changes
Feb 17, 2024
kingster-will
referenced
this pull request
in kingster-will/protocol-core-v1-dev
Mar 19, 2024
…col#108) * remove ipaccountiml initialize()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an optimization to the IPAccountImpl contract by embedding the initialization of the AccessController directly within the constructor, eliminating the need for external calls to initialize() for each IPAccount registration. This change streamlines the process, enhancing efficiency and reducing gas costs associated with IPAccount setup.
All existing tests have been updated to reflect this change.