Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

test: More licensing and UML PFM tests #114

Merged
merged 11 commits into from
Feb 17, 2024
Merged

test: More licensing and UML PFM tests #114

merged 11 commits into from
Feb 17, 2024

Conversation

jdubpark
Copy link
Contributor

@jdubpark jdubpark commented Feb 17, 2024 •
edited
Loading

  • Polished integration tests, including a new integration test for royalty flows
  • More unit tests and coverage, standardize inheritance to BaseTest
  • Reinstate a logic removed during mintLicense in add upfront minting fee #113
ROYALTY_MODULE.onLicenseMinting(licensorIpId, pol.royaltyPolicy, pol.royaltyData, royaltyContext);

@jdubpark jdubpark marked this pull request as ready for review February 17, 2024 14:55
@jdubpark jdubpark requested a review from a team February 17, 2024 14:55
@LeoHChen LeoHChen merged commit 03b8c2b into storyprotocol:main Feb 17, 2024
1 check passed
kingster-will referenced this pull request in kingster-will/protocol-core-v1-dev Mar 19, 2024
@jdubpark @kingster-will
test: More licensing and UML PFM tests (storyprotocol#114)
0f32ffe 
* test: more licensing and UML PFM tests
* test: New Integration test for Royalty flows

* fix: Reinstate  call to RoyaltyModule in LicensingModule when minting licenses

* refactor: rebase renaming to PIL
* refactor: Modify tests to inherit and use BaseTest
* refactor: token alias
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Spablob Spablob Spablob left review comments

@LeoHChen LeoHChen LeoHChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdubpark @LeoHChen @Spablob