Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

PIL flavors library #123

Merged
merged 4 commits into from
Feb 22, 2024
Merged

PIL flavors library #123

merged 4 commits into from
Feb 22, 2024

Conversation

Ramarti
Copy link
Contributor

@Ramarti Ramarti commented Feb 19, 2024

  • Library to get the pre set PIL Flavors (Policy presets) from smart contracts.
  • Integration test using them

@Ramarti Ramarti marked this pull request as ready for review February 20, 2024 00:51
@Ramarti Ramarti requested review from jdubpark, kingster-will and a team February 20, 2024 00:51
Copy link
Member

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs @jdubpark 's review. Make sure all naming, linting, and comments are in-place.

Copy link
Member

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally okay

@jdubpark
Copy link
Contributor

Looks good to me based on the latest updates aeceb48

@LeoHChen LeoHChen merged commit c13a9d7 into storyprotocol:main Feb 22, 2024
1 check passed
kingster-will referenced this pull request in kingster-will/protocol-core-v1-dev Mar 19, 2024
* add a few PIL flavors libraries to improve DevEx
@AndyBoWu AndyBoWu mentioned this pull request Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants