This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
generated from storyprotocol/solidity-template
-
Notifications
You must be signed in to change notification settings - Fork 70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ramarti
commented
Feb 19, 2024
•
edited
Loading
edited
- Library to get the pre set PIL Flavors (Policy presets) from smart contracts.
- Integration test using them
LeoHChen
reviewed
Feb 20, 2024
LeoHChen
reviewed
Feb 20, 2024
LeoHChen
suggested changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs @jdubpark 's review. Make sure all naming, linting, and comments are in-place.
LeoHChen
reviewed
Feb 20, 2024
LeoHChen
reviewed
Feb 20, 2024
LeoHChen
reviewed
Feb 20, 2024
LeoHChen
reviewed
Feb 22, 2024
LeoHChen
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally okay
Looks good to me based on the latest updates aeceb48 |
LeoHChen
approved these changes
Feb 22, 2024
LeoHChen
approved these changes
Feb 22, 2024
kingster-will
referenced
this pull request
in kingster-will/protocol-core-v1-dev
Mar 19, 2024
* add a few PIL flavors libraries to improve DevEx
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.