This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Refactored Licensing from parameter based to framework based. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
requested review from
jdubpark,
leeren,
kingster-will,
LeoHChen,
jzhao23 and
Spablob
and removed request for
jdubpark and
leeren
leeren
approved these changes
Jan 29, 2024
contracts/modules/licensing/parameter-helpers/LicensorApprovalManager.sol
Show resolved
Hide resolved
jzhao23
reviewed
Jan 30, 2024
jzhao23
reviewed
Jan 30, 2024
jzhao23
reviewed
Jan 30, 2024
jzhao23
reviewed
Jan 30, 2024
jzhao23
reviewed
Jan 30, 2024
jzhao23
reviewed
Jan 30, 2024
jzhao23
reviewed
Jan 30, 2024
jzhao23
reviewed
Jan 30, 2024
jzhao23
reviewed
Jan 30, 2024
contracts/modules/licensing/parameter-helpers/LicensorApprovalManager.sol
Show resolved
Hide resolved
jzhao23
reviewed
Jan 30, 2024
contracts/modules/licensing/parameter-helpers/LicensorApprovalManager.sol
Show resolved
Hide resolved
jzhao23
reviewed
Jan 30, 2024
jzhao23
reviewed
Jan 30, 2024
jzhao23
reviewed
Jan 30, 2024
LeoHChen
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
IMO, the change is already too big to review carefully. Since it is a big refactoring code, to make it easier to review.
Please do
- Rebase the PR to the latest code
- Make it runnable
- Add test cases to provide better coverage
- Add integration test, working with @jdubpark
- Merge the code
Host a review session separately for the entire licensing policy and framework.
jdubpark
force-pushed
the
framework_based_licensing
branch
from
b7607c1
to
1e4aa74
Compare
jdubpark
added a commit
that referenced
this pull request
Jan 31, 2024
* refactored licensing from param based to fw based * test policy integrity * test tranferability * feat: Integration test work, Script mods, Mock type changes, linting and refactoring * renamed setByLinking to inherited policy * refactor LicenseFramework into PolicyFramework * refactor naming to policy framework * comments and linting * Update contracts/interfaces/licensing/IMintParamVerifier.sol * Update contracts/interfaces/licensing/IPolicyFrameworkManager.sol * refactor frameworkId to policyFrameworkId * moved UMLFramework errors to another file * rename IParamVerifier into IPolicyVerifier * Adding Access Control to License * feat: License NFT URI for UMLPolicyFrameworkManager, test and lint * refactored licensing from param based to fw based * refactor naming to policy framework * comments and linting * rename IParamVerifier into IPolicyVerifier --------- Co-authored-by: Raul <raul@proofofcode.dev> Co-authored-by: Jongwon Park <jwparktom@gmail.com> Co-authored-by: Kingster <atarneo2015@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Creating policies (values representing a particular licensing template, like UML)
-- Verifying those policies make sense before registering into the LicenseRegistry
-- Encoding and decoding them into the LicenseRegistry
-- Verifying licensing parameter compliance
As an analogy with BalancerV2, LicenseRegistry is our Vault, and each PolicyFrameworkManager defines each pool's logic.